-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35133][Connectors/Cassandra] Adding support for Flink 1.19 #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for standardising the conectors @dannycranmer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed after commit 😢 but LGTM. Just a single interrogation
if: github.repository_owner == 'apache' | ||
strategy: | ||
matrix: | ||
flink_branches: [{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is true that all the PRs are tested against last 2 Flink versions but don't you think that the weekly workflow should also test against these versions and not only the snapshots ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense. I need to update to include the new v3.2 branch, so will add them then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect 👍
uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils | ||
with: | ||
flink_version: 1.17.2 | ||
connector_branch: main | ||
skip_archunit_tests: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool that we no more need to test against 1.17.2 and skip the archunit tests !
No description provided.